Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LabelSet.String: restore faster sort call #619

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

bboreham
Copy link
Member

This was changed without explanation at #617; let's put it back.

goos: darwin
goarch: arm64
pkg: github.com/prometheus/common/model
                       │ before.txt  │             after.txt              │
                       │   sec/op    │   sec/op     vs base               │
LabelSetStringMethod-8   500.4n ± 0%   434.4n ± 0%  -13.19% (p=0.002 n=6)

                       │ before.txt  │             after.txt             │
                       │    B/op     │    B/op     vs base               │
LabelSetStringMethod-8   616.00 ± 0%   80.00 ± 0%  -87.01% (p=0.002 n=6)

                       │ before.txt │             after.txt             │
                       │ allocs/op  │ allocs/op   vs base               │
LabelSetStringMethod-8   3.000 ± 0%   1.000 ± 0%  -66.67% (p=0.002 n=6)

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also taking care of the fix!

@ArthurSens ArthurSens merged commit e25b951 into prometheus:main Apr 18, 2024
7 checks passed
codeboten referenced this pull request in open-telemetry/opentelemetry-collector Apr 23, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/prometheus/common](https://togithub.com/prometheus/common)
| `v0.52.3` -> `v0.53.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.52.3/v0.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.52.3/v0.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>prometheus/common (github.com/prometheus/common)</summary>

###
[`v0.53.0`](https://togithub.com/prometheus/common/releases/tag/v0.53.0)

[Compare
Source](https://togithub.com/prometheus/common/compare/v0.52.3...v0.53.0)

#### What's Changed

- Add StatusAt method for Alert struct by
[@&#8203;grobinson-grafana](https://togithub.com/grobinson-grafana) in
[https://github.com/prometheus/common/pull/618](https://togithub.com/prometheus/common/pull/618)
- config: allow exposing real secret value through marshal by
[@&#8203;GiedriusS](https://togithub.com/GiedriusS) in
[https://github.com/prometheus/common/pull/487](https://togithub.com/prometheus/common/pull/487)
- Fix up config test by [@&#8203;SuperQ](https://togithub.com/SuperQ) in
[https://github.com/prometheus/common/pull/621](https://togithub.com/prometheus/common/pull/621)
- LabelSet.String: restore faster sort call by
[@&#8203;bboreham](https://togithub.com/bboreham) in
[https://github.com/prometheus/common/pull/619](https://togithub.com/prometheus/common/pull/619)
- LabelSet: add unit test for String method by
[@&#8203;bboreham](https://togithub.com/bboreham) in
[https://github.com/prometheus/common/pull/620](https://togithub.com/prometheus/common/pull/620)

#### New Contributors

- [@&#8203;grobinson-grafana](https://togithub.com/grobinson-grafana)
made their first contribution in
[https://github.com/prometheus/common/pull/618](https://togithub.com/prometheus/common/pull/618)
- [@&#8203;GiedriusS](https://togithub.com/GiedriusS) made their first
contribution in
[https://github.com/prometheus/common/pull/487](https://togithub.com/prometheus/common/pull/487)

**Full Changelog**:
prometheus/common@v0.52.3...v0.53.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
codeboten referenced this pull request in open-telemetry/opentelemetry-collector-contrib Apr 23, 2024
)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/prometheus/common](https://togithub.com/prometheus/common)
| `v0.52.3` -> `v0.53.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.52.3/v0.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.52.3/v0.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>prometheus/common (github.com/prometheus/common)</summary>

###
[`v0.53.0`](https://togithub.com/prometheus/common/releases/tag/v0.53.0)

[Compare
Source](https://togithub.com/prometheus/common/compare/v0.52.3...v0.53.0)

#### What's Changed

- Add StatusAt method for Alert struct by
[@&#8203;grobinson-grafana](https://togithub.com/grobinson-grafana) in
[https://github.com/prometheus/common/pull/618](https://togithub.com/prometheus/common/pull/618)
- config: allow exposing real secret value through marshal by
[@&#8203;GiedriusS](https://togithub.com/GiedriusS) in
[https://github.com/prometheus/common/pull/487](https://togithub.com/prometheus/common/pull/487)
- Fix up config test by [@&#8203;SuperQ](https://togithub.com/SuperQ) in
[https://github.com/prometheus/common/pull/621](https://togithub.com/prometheus/common/pull/621)
- LabelSet.String: restore faster sort call by
[@&#8203;bboreham](https://togithub.com/bboreham) in
[https://github.com/prometheus/common/pull/619](https://togithub.com/prometheus/common/pull/619)
- LabelSet: add unit test for String method by
[@&#8203;bboreham](https://togithub.com/bboreham) in
[https://github.com/prometheus/common/pull/620](https://togithub.com/prometheus/common/pull/620)

#### New Contributors

- [@&#8203;grobinson-grafana](https://togithub.com/grobinson-grafana)
made their first contribution in
[https://github.com/prometheus/common/pull/618](https://togithub.com/prometheus/common/pull/618)
- [@&#8203;GiedriusS](https://togithub.com/GiedriusS) made their first
contribution in
[https://github.com/prometheus/common/pull/487](https://togithub.com/prometheus/common/pull/487)

**Full Changelog**:
prometheus/common@v0.52.3...v0.53.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
andrzej-stencel referenced this pull request in andrzej-stencel/opentelemetry-collector May 27, 2024
…#10021)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/prometheus/common](https://togithub.com/prometheus/common)
| `v0.52.3` -> `v0.53.0` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.52.3/v0.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.52.3/v0.53.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>prometheus/common (github.com/prometheus/common)</summary>

###
[`v0.53.0`](https://togithub.com/prometheus/common/releases/tag/v0.53.0)

[Compare
Source](https://togithub.com/prometheus/common/compare/v0.52.3...v0.53.0)

#### What's Changed

- Add StatusAt method for Alert struct by
[@&open-telemetry#8203;grobinson-grafana](https://togithub.com/grobinson-grafana) in
[https://github.com/prometheus/common/pull/618](https://togithub.com/prometheus/common/pull/618)
- config: allow exposing real secret value through marshal by
[@&open-telemetry#8203;GiedriusS](https://togithub.com/GiedriusS) in
[https://github.com/prometheus/common/pull/487](https://togithub.com/prometheus/common/pull/487)
- Fix up config test by [@&open-telemetry#8203;SuperQ](https://togithub.com/SuperQ) in
[https://github.com/prometheus/common/pull/621](https://togithub.com/prometheus/common/pull/621)
- LabelSet.String: restore faster sort call by
[@&open-telemetry#8203;bboreham](https://togithub.com/bboreham) in
[https://github.com/prometheus/common/pull/619](https://togithub.com/prometheus/common/pull/619)
- LabelSet: add unit test for String method by
[@&open-telemetry#8203;bboreham](https://togithub.com/bboreham) in
[https://github.com/prometheus/common/pull/620](https://togithub.com/prometheus/common/pull/620)

#### New Contributors

- [@&open-telemetry#8203;grobinson-grafana](https://togithub.com/grobinson-grafana)
made their first contribution in
[https://github.com/prometheus/common/pull/618](https://togithub.com/prometheus/common/pull/618)
- [@&open-telemetry#8203;GiedriusS](https://togithub.com/GiedriusS) made their first
contribution in
[https://github.com/prometheus/common/pull/487](https://togithub.com/prometheus/common/pull/487)

**Full Changelog**:
prometheus/common@v0.52.3...v0.53.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/open-telemetry/opentelemetry-collector).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMTMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjMxMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJyZW5vdmF0ZWJvdCJdfQ==-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants